Changeset 1553

Timestamp:

12/03/2006 05:29:46 PM (23 months ago)

Author:

wei

Message:

Fixed #400

Location:

branches/3.0

Files:

• HISTORY (modified) (2 diffs)
• UPGRADE (modified) (1 diff)
• framework/Web/Javascripts/extra/logger.js (modified) (3 diffs)
• framework/Web/Javascripts/js/compressed/logger.js (modified) (3 diffs)
• framework/Web/Javascripts/js/debug/logger.js (modified) (3 diffs)
• framework/Web/UI/WebControls/TJavascriptLogger.php (modified) (4 diffs)

branches/3.0/HISTORY

@@ -1 +1 @@
 Version 3.0.6 December 4, 2006
 ==============================
+BUG: Ticket#400 - TJavascriptLogger incompatible with Firefox 2.0 RC1 (Wei)
 BUG: Ticket#442 - TPageService getBasePath in namespace form (Qiang)
 BUG: Ticket#443 - Template comment tag messed up with HTML comment tag (Qiang)
@@ -8 +9 @@
 BUG: global state was not saved when redirect() is invoked (Qiang)
 BUG: TPager would not display if it was invisible previously (Qiang)
+BUG: Ticket#476 - Problem when adding a new text (translate) with MessageSource_XLIFF (Wei)
 ENH: Ticket#446 - Added TMetaTagCollection.getMetaTagByID method (Qiang)
 ENH: Ticket#451 - Modified TUrlMapping to extend from TUrlManager (Qiang)
 ENH: Ticket#468 - Added support of using all property tags in skins (Qiang)
 ENH: Ticket#471 - Added methods in TAssetManager to expose published path and URL (Qiang)
+ENH: Add ToggleKey for TJavascriptLogger (Wei)
 CHG: Ticket#437 - __autoload is replaced by spl_autoload_register (Qiang)
 CHG: Ticket#454 - Redundant PHP Version Check (Qiang)

branches/3.0/UPGRADE

@@ -23 +23 @@
 - If TUrlMapping is used, you need to set the UrlManager property of
   THttpRequest to the module ID of TUrlMapping.
+- TJavascriptLogger toggle key is changed from ALT-D to ALT-J. 
+   Use the ToggleKey property chanage to a different key.
 
 Upgrading from v3.0.4

branches/3.0/framework/Web/Javascripts/extra/logger.js

@@ -201 +201 @@
   // -------
 
-  initialize : function() {
+  initialize : function(toggleKey) {
     this.outputCount = 0
     this.tagPattern = Cookie.get('tagPattern') || ".*"
@@ -284 +284 @@
                 this.logElement.style.bottom="0px";
         }
+        var self=this;
+        Event.observe(document, 'keydown', function(e)
+        { 
+                if((e.altKey==true) && Event.keyCode(e) == toggleKey ) //Alt+J | Ctrl+J
+                        self.toggle();
+        });
 
     // Listen to the logger....
@@ -452 +458 @@
         }
 }
-
-// Load the Console when the window loads
-var logConsole;
-Event.OnLoad(function() { logConsole = new LogConsole()});
-
-
 
 

branches/3.0/framework/Web/Javascripts/js/compressed/logger.js

@@ -41 +41 @@
 this.tag=tag}}
 LogConsole=Class.create()
-LogConsole.prototype={commandHistory:[],commandIndex:0,hidden:true,initialize:function(){this.outputCount=0
+LogConsole.prototype={commandHistory:[],commandIndex:0,hidden:true,initialize:function(toggleKey){this.outputCount=0
 this.tagPattern=Cookie.get('tagPattern')||".*"
 this.logElement=document.createElement('div')
@@ -98 +98 @@
 else
 {this.logElement.style.position="fixed";this.logElement.style.bottom="0px";}
-Logger.onupdate.addListener(this.logUpdate.bind(this))
+var self=this;Event.observe(document,'keydown',function(e)
+{if((e.altKey==true)&&Event.keyCode(e)==toggleKey)
+self.toggle();});Logger.onupdate.addListener(this.logUpdate.bind(this))
 Logger.onclear.addListener(this.clear.bind(this))
 for(var i=0;i<Logger.logEntries.length;i++){this.logUpdate(Logger.logEntries[i])}
@@ -153 +155 @@
 this.inputElement.value=this.commandHistory[this.commandIndex]}
 else{this.commandIndex=0}}}
-var logConsole;Event.OnLoad(function(){logConsole=new LogConsole()});function inspect(o)
+function inspect(o)
 {var objtype=typeof(o);if(objtype=="undefined"){return"undefined";}else if(objtype=="number"||objtype=="boolean"){return o+"";}else if(o===null){return"null";}
 try{var ostring=(o+"");}catch(e){return"["+typeof(o)+"]";}

branches/3.0/framework/Web/Javascripts/js/debug/logger.js

@@ -201 +201 @@
   // -------
 
-  initialize : function() {
+  initialize : function(toggleKey) {
     this.outputCount = 0
     this.tagPattern = Cookie.get('tagPattern') || ".*"
@@ -284 +284 @@
                 this.logElement.style.bottom="0px";
         }
+        var self=this;
+        Event.observe(document, 'keydown', function(e)
+        { 
+                if((e.altKey==true) && Event.keyCode(e) == toggleKey ) //Alt+J | Ctrl+J
+                        self.toggle();
+        });
 
     // Listen to the logger....
@@ -452 +458 @@
         }
 }
-
-// Load the Console when the window loads
-var logConsole;
-Event.OnLoad(function() { logConsole = new LogConsole()});
-
-
 
 

branches/3.0/framework/Web/UI/WebControls/TJavascriptLogger.php

@@ -33 +33 @@
 class TJavascriptLogger extends TWebControl
 {
+        private static $_keyCodes = array(
+                '0'=>48, '1'=>49, '2'=>50, '3'=>51, '4'=>52, '5'=>53, '6'=>54, '7'=>55, '8'=>56, '9'=>57, 
+                'a'=>65, 'b'=>66, 'c'=>67, 'd'=>68, 'e'=>69, 'f'=>70, 'g'=>71, 'h'=>72,
+                'i'=>73, 'j'=>74, 'k'=>75, 'l'=>76, 'm'=>77, 'n'=>78, 'o'=>79, 'p'=>80,
+                'q'=>81, 'r'=>82, 's'=>83, 't'=>84, 'u'=>85, 'v'=>86, 'w'=>87, 'x'=>88, 'y'=>89, 'z'=>90);
+
         /**
          * @return string tag name of the panel
@@ -42 +48 @@
 
         /**
+         * @param string keyboard key for toggling the console, default is J.
+         */
+        public function setToggleKey($value)
+        {
+                $this->setViewState('ToggleKey', $value, 'j');
+        }
+
+        /**
+         * @return string keyboard key for toggling the console.
+         */
+        public function getToggleKey()
+        {
+                return $this->getViewState('ToggleKey', 'j');
+        }
+
+        /**
          * Registers the required logger javascript.
          * @param TEventParameter event parameter
@@ -47 +69 @@
         public function onPreRender($param)
         {
-                $this->getPage()->getClientScript()->registerPradoScript('logger');
+                $key = strtolower($this->getToggleKey());
+                $code = isset(self::$_keyCodes[$key]) ? self::$_keyCodes[$key] : 74;
+                $js = "var logConsole; Event.OnLoad(function() { logConsole = new LogConsole($code)}); ";
+                $cs = $this->getPage()->getClientScript();
+                $cs->registerBeginScript($this->getClientID(),$js);
+                $cs->registerPradoScript('logger');
         }
 
@@ -57 +84 @@
         public function renderContents($writer)
         {
+                $code = strtoupper($this->getToggleKey());
                 $info = '(<a href="http://gleepglop.com/javascripts/logger/" target="_blank">more info</a>).';
                 $link = '<a href="javascript:if(logConsole)logConsole.toggle()">toggle the javascript log console.</a>';
-                $usage = 'Press ALT-D (Or CTRL-D on OS X) to';
+                $usage = 'Press ALT-'.$code.' (Or CTRL-'.$code.' on OS X) to';
                 $writer->write("{$usage} {$link} {$info}");
         }