Ticket #744 (closed defect: fixed)
Error in error handling
| Reported by: | stever | Owned by: | xue |
|---|---|---|---|
| Priority: | low | Milestone: | 3.1.2 |
| Component: | Prado Framework v3 | Version: | 3.1 |
| Severity: | minor | Keywords: | |
| Cc: |
Description
In callbacks, when there is a fatal PHP error, it causes a JS error as well.
/**
* Respond to Prado Callback request exceptions.
*/
Exception :
{
/**
* Server returns 500 exception. Just log it.
*/
"on500" : function(request, transport, data)
{
var e = request.getHeaderData(Prado.CallbackRequest.ERROR_HEADER);
Logger.error("Callback Server Error "+e.code, this.formatException(e));
},
If there was a fatal error, the error header never gets set, so var e=null above, and e.code causes a JS error. Better if it looked like this (or similar):
/**
* Respond to Prado Callback request exceptions.
*/
Exception :
{
/**
* Server returns 500 exception. Just log it.
*/
"on500" : function(request, transport, data)
{
var e = request.getHeaderData(Prado.CallbackRequest.ERROR_HEADER);
if (e)
Logger.error("Callback Server Error "+e.code, this.formatException(e));
else
Logger.error("Callback Server Error Unknown",'');
},
Change History
Note: See
TracTickets for help on using
tickets.
