PradoBase createCompenent fix:

[jake]

This part of the code isn't exactly broken but its using eval which should really never be used.

Under the static method createComponent() where eval is used like so...

eval("\$component=new $type($s);");

That could be changed to...

$component=new $type($s);

The code is now even simpler and reduces the security risk that eval imposes of running PHP code.

Regards, - jake

[durgis]

Good call Jake, I always thought the use of eval there seemed inappropriate.

Brad

[xue]

We use eval() here to allow passing parameters to constructor. Your change is not correct. If you can come up with an approach that avoids using eval(), it will be great!